Update schema versions for ES visibility store #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackburn29
force-pushed
the
vis_es_schema_upgrade
branch
2 times, most recently
from
3e101a7 to
dd7c177
Compare
alexandrevilain
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Thanks for your contribution @Blackburn29 :)
Waiting for e2e to be green to merge this.
Closed
Blackburn29
force-pushed
the
vis_es_schema_upgrade
branch
from
dd7c177 to
b710ea7
Compare
|
|
Unfortunately I'm not able to reproduce the failed cassandra test. I have upgraded 2 temporal clusters from 1.23 to 1.24.3 using an image built from this branch without issues |
alexandrevilain
approved these changes
Nov 3, 2024
|
Thanks for your work @Blackburn29 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 AV schema updates are required for 1.24. These appear to be missing from the update-visibility-schema.sh template. This PR adds them