feat(helm): Add option to use webhook with host network #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevilain
approved these changes
Nov 25, 2024
alexandrevilain
requested changes
Nov 25, 2024
|
Could you please suash your commits @ttretau ? :) |
ttretau
force-pushed
the
feat/helm_hostnetwork_option
branch
from
31b62d6 to
66ceb38
Compare
alexandrevilain
approved these changes
Nov 25, 2024
This adds the option to configure the webhook to use host network. Useful for example in managed EKS clusters. The Helm docs have been newly generated. The Helm chart version was updated, pointing now to the last app release.
ttretau
force-pushed
the
feat/helm_hostnetwork_option
branch
from
66ceb38 to
d3b714a
Compare
|
|
Thanks @alexandrevilain, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to configure the webhook to use host network. Useful for example in managed EKS clusters where the admission webhook does not work.
The Helm docs have been newly generated.
The Helm chart version was updated, pointing now to the last app release.
This fixes #847.