Update base.py

[kartiksubbarao]

Only join symbols if passed as a list, fixes #53

[kolyarice]

testing this fix this morning, I found that the API returns an error if the length of the symbols search str is too short:

In [2]: r = c.get_instruments(symbols='A.*', projection=schwab.client.Client.Instrument.Projection.SYMBOL_REGEX)

In [3]: r.json()
Out[3]:
{'errors': [{'id': 'e86350c5-ee29-43ff-ac71-e57dc90a9155',
   'status': '400',
   'title': 'Bad Request',
   'detail': 'Symbol length should be atleast : 4',
   'source': {'parameter': 'symbol'}}]}

testing with AA.* succeeded ✅
(testing with [A].* failed successfully, because the result set was too large)

[alexgolec]

This is not currently intended functionality. Closing for now.

[pengdahl]

Please re-open this request. It is not possible to use symbol-regex in get_instruments with the current version. I had to fork this repo in order to fix this myself since I use symbol-regex.

[kartiksubbarao]

@pengdahl FYI the corresponding issue is #53 which is still open. I followed up there with @alexgolec since I didn't understand his response here. Hopefully he can respond with some more clarification.

[pengdahl]

It’s pretty simple - his patch makes the symbol go through as-is if it isn’t a list. That is necessary for regex because regex requires an unmodified string for the symbol. I have tested his patch and I can confirm that it works.On Jun 2, 2024, at 2:24 PM, Kartik Subbarao ***@***.***> wrote: @pengdahl FYI the corresponding issue is #53 which is still open. I followed up there with @alexgolec since I didn't understand his response here. Hopefully he can respond with some more clarification. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>