Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/get exchange rate #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sigularusrex
Copy link

It would be great to make fetching rates a little more explicit. If you agree, I'll update the readme too.

For now, tests are failing on my repo

@alexprengere
Copy link
Owner

alexprengere commented Nov 14, 2023

Thanks for the idea. I wonder if this is really useful though, as it is basically a partial on c.convert().

@Sigularusrex
Copy link
Author

@alexprengere thanks for checking this.

You're right, it makes fetching rates a little more explicit rather than having to derive the conversion rate from
c.convert(1 'EUR', 'NOK')

I think it's a nice quality of life improvement to have a separate function for this, so you can
c.get_exchange_rate('EUR' 'NOK')

But it's your call. lmk if you'd like to continue or feel free to close the PR.

Repository owner deleted a comment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants