Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Characters package #1344

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Introduce Characters package #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f2c0fb
Update alr.ads
jquorning Mar 13, 2023
b31f934
Update alr-testing-text.adb
jquorning Mar 13, 2023
ba612ac
Update alr-testing-junit.adb
jquorning Mar 13, 2023
9e5e02f
Update alr-testing-console.adb
jquorning Mar 13, 2023
2192b47
Ada 83 ASCII
jquorning Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/alr/alr-testing-console.adb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ with Stopwatch;

package body Alr.Testing.Console is

Tab : constant Character := ASCII.HT;
Tab : constant Character := Characters.HT;

---------------
-- Start_Run --
Expand Down
2 changes: 1 addition & 1 deletion src/alr/alr-testing-junit.adb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ with Alr.Commands.Version;

package body Alr.Testing.JUnit is

Newline : constant String := "" & ASCII.LF;
Newline : constant String := "" & Characters.LF;

---------------
-- Start_Run --
Expand Down
2 changes: 1 addition & 1 deletion src/alr/alr-testing-text.adb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package body Alr.Testing.Text is

use Ada.Text_IO;

Tab : constant Character := ASCII.HT;
Tab : constant Character := Characters.HT;

---------------
-- Start_Run --
Expand Down
1 change: 1 addition & 0 deletions src/alr/alr.ads
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ package Alr with Preelaborate is
use all type Simple_Logging.Levels;
pragma Warnings (On);

package Characters renames ASCII;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the way to go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea is to avoid ASCII because of obsolescence, I'd say Ada.Characters.Latin_1 is preferable.

package Trace renames Simple_Logging;
package TTY renames CLIC.TTY;

Expand Down