Undo overwriting of protobufs since v0.3.0 #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
#528 and others overwite the protobuf in the v2 folder of the emissions module. this is the incorrect way to perform software upgrades.
Future changes to protobufs must go in their own v3 folder and the v2 must stay pinned to v0.3.0
This PR reverts the changes and introduces a new v3 folder for working with.
Link(s) to Ticket(s) or Issue(s) resolved by this PR
No written linear tasks.
Are these changes tested and documented?
Covered by existing unit tests.
Still Left Todo
Migrations for the new parameters in #528. I already wrote migration code in #525 and #529 so I recommend either basing off of those or waiting for at a miniumum, #525 to be merged.