Wrap endblock #531
Wrap endblock #531
Conversation
…tential-panics-in-abci-methods
x/emissions/module/module.go
Outdated
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| if r := recover(); r != nil { | ||
| err := fmt.Errorf("recovered from panic in EndBlocker: %v", r) | ||
| sdkCtx.Logger().Error("Error Getting module params", err) |
| sdkCtx.Logger().Error("Error Getting module params", err) | ||
| } | ||
| }() | ||
|
|
||
| err := EndBlocker(ctx, am) | ||
| if err != nil { | ||
| sdkCtx := sdk.UnwrapSDKContext(ctx) |
There was a problem hiding this comment.
can we fix this typo in this PR too: EnbBlocker
There was a problem hiding this comment.
(it's the line below this one, won't let me leave a comment on just that line)
|
I am confused how this PR works, is this just going to catch panics on unwrapping the sdk context? |
…tential-panics-in-abci-methods
…tential-panics-in-abci-methods
|
@relyt29 I can understand why you are confused on this change. I think it is because I got |
kpeluso
deleted the
michaelc/proto-1956-security-issues-report-potential-panics-in-abci-methods
branch
Purpose of Changes and their Description
Implemented a wrapper function for EndBlocker to catch and handle any potential panics
Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?Still Left Todo
Fill this out if this is a Draft PR so others can help.