Protobuf linter

[fernandofcampos]

Purpose of Changes and their Description

Use Buf as a linter for protobufs.

Link(s) to Ticket(s) or Issue(s) resolved by this PR

https://linear.app/alloralabs/issue/PROTO-2132

Are these changes tested and documented?

Covered by existing unit tests and integration tests.

Still Left Todo

Fill this out if this is a Draft PR so others can help.

[github-actions]

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	⏩ skipped	✅ passed	⏩ skipped	Aug 18, 2024, 10:05 PM

[github-actions]

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	✅ passed	✅ passed	⏩ skipped	Aug 19, 2024, 3:55 PM

[relyt29]

I looked over some of the changes but I just want to make explicitly sure: none of the actual contents of the .proto files have been changed, right, the protos are just being reformatted with a different formatter right?

[relyt29]

oh another question: if we have this new linter, what will be the new formatter command to format our protobufs for us (and does it have a visual studio code integation)

[fernandofcampos]

I looked over some of the changes but I just want to make explicitly sure: none of the actual contents of the .proto files have been changed, right, the protos are just being reformatted with a different formatter right?

Some were changed. Please check my first commit: 1626cb1

It has all changes related to the linter findings. The second commit has the reformat changes.

[fernandofcampos]

oh another question: if we have this new linter, what will be the new formatter command to format our protobufs for us (and does it have a visual studio code integation)

The linter and the formatter use the same tool, Buf, that was already being used to generate the protobufs.

If you run make on x/emissions/Makefile (for instance) it will format, lint and generate. But there is a separated command to format: make proto-format

Let me know if you want me to change it. I will check about VSCode.

[fernandofcampos]

oh another question: if we have this new linter, what will be the new formatter command to format our protobufs for us (and does it have a visual studio code integation)

There is a VSCode extension: https://marketplace.visualstudio.com/items?itemName=bufbuild.vscode-buf

[relyt29]

can we not delete the build and test commands? I use them

[relyt29]

same comment here, I object to the removal of make build and make test

[relyt29]

Ok I looked over the commit you highlighted and also then the total PR

left two comments about a minor thing, please don't delete make test and make build other than that I'm good with the changes