Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added telemetry and removed unnecessary logs #535

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Added telemetry and removed unnecessary logs #535

merged 5 commits into from
Aug 21, 2024

Conversation

guilherme-brandao
Copy link
Contributor

  • Remove unnecessary fmt.Print statements
  • Added telemetry + new endblock metric for emissions module

relyt29
relyt29 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@relyt29 relyt29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration test is failing because it's flakey. if you re run it it will likely pass

we should probably create a ticket to look into it at some point. I am not sure why the integration test has suddenly decided to be flakey when it wasn't before

@guilherme-brandao guilherme-brandao merged commit c49aeec into dev Aug 21, 2024
7 checks passed
@guilherme-brandao guilherme-brandao deleted the guilherme/proto-2205-unify-logging-approaches-and-add-cosmos-telemetry branch August 21, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relyt29 relyt29 relyt29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilherme-brandao @relyt29