simplify util_sort.go FindTopNByScoreDesc #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relyt29
changed the title
relyt29
requested review from
kpeluso,
RedBird96,
fernandofcampos,
xmariachi and
guilherme-brandao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
As part of #421 I need to add features to util_sort for getting the top list of actors by score. I also observed some ways to make the
FindTopNByScoreDescfunction simpler as part of that effort. But due to the high level of importance of this code I wanted to do a refactor of this function in an isolated manner to make sure that no changes that affect tests / state are made by the way I rewrote the function. Hence this PRLink(s) to Ticket(s) or Issue(s) resolved by this PR
Related to PROTO-2204
Are these changes tested and documented?
This code is a refactor and so it is tested by our existing unit tests to ensure that no logical changes have been made.