Implementation of a linter to list range loops over a map #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
fernandofcampos
force-pushed
the
PROTO-2144
branch
from
242ba31 to
9fdd825
Compare
fernandofcampos
force-pushed
the
PROTO-2144
branch
from
9fdd825 to
fdf2c3f
Compare
kpeluso
reviewed
Aug 27, 2024
| - ".*\\.pb\\.go" | ||
| - ".*\\.pb\\.gw\\.go" | ||
| - ".*\\.pulsar\\.go" | ||
| - ".*_mocks\\.go" |
There was a problem hiding this comment.
should you exclude the linter dir itself so you can keep your test?
There was a problem hiding this comment.
It is not reporting anything on my tests, which is strange. Investigating why, golangci automatically excludes these dirs:
vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
So we don't need to add the linter dir.
kpeluso
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Implementing a linter to list range loops over a map, so we can identify those cases more easily.
Link(s) to Ticket(s) or Issue(s) resolved by this PR
https://linear.app/alloralabs/issue/PROTO-2144/linter-to-throw-if-iterating-over-a-map
Are these changes tested and documented?
Yes. New tests were added to validate the linter. The new linter is not enabled on golangci.yml, so it won't interfere with the current lint checks.
Still Left Todo
Fill this out if this is a Draft PR so others can help.