Mint module GenesisState, proto, and v3 no-op migration #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relyt29
requested review from
xmariachi,
fernandofcampos,
kpeluso,
spooktheducks,
amimart and
guilherme-brandao
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
relyt29
force-pushed
the
tyler/proto-2787-change-mint-module-vesting-schedule-to-use-integral-math
branch
from
0a970f4 to
f9fc547
Compare
relyt29
force-pushed
the
tyler/proto-2787-change-mint-module-vesting-schedule-to-use-integral-math
branch
from
f9fc547 to
7181c6b
Compare
xmariachi
reviewed
Dec 4, 2024
xmariachi
reviewed
Dec 4, 2024
relyt29
force-pushed
the
tyler/proto-2787-change-mint-module-vesting-schedule-to-use-integral-math
branch
from
9468a88 to
b54896e
Compare
kpeluso
requested changes
Dec 4, 2024
kpeluso
approved these changes
Dec 4, 2024
amimart
approved these changes
Dec 4, 2024
kpeluso
deleted the
tyler/proto-2787-change-mint-module-vesting-schedule-to-use-integral-math
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
As we're going through the v0.7.0 upgrade checklist I observed that PR #690 was missing
GenesisStateupdates for the new keeper field. And since the errors are updated, AND since there's a new keeper field it probably makes sense to bump theConsensusVersionof the mint module. I also added a migration for the mint module which is a no-op, just a print line that tells you that the mint module was upgraded!Link(s) to Ticket(s) or Issue(s) resolved by this PR
PROTO-2787
Are these changes tested and documented?
These tests will have to be tested by hand as part of the v0.7.0 checklist upgrade flow.