Add Emission Enabled bolean flag to Mint Module #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relyt29
requested review from
xmariachi,
fernandofcampos,
kpeluso,
spooktheducks,
amimart and
guilherme-brandao
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
relyt29
force-pushed
the
tyler/proto-3083-add-mint-rewards-emissions-enabled-boolean-flag
branch
2 times, most recently
from
a1b1ba7 to
22ebf8a
Compare
|
|
relyt29
force-pushed
the
tyler/proto-3083-add-mint-rewards-emissions-enabled-boolean-flag
branch
from
22ebf8a to
dcf804f
Compare
relyt29
force-pushed
the
tyler/proto-3083-add-mint-rewards-emissions-enabled-boolean-flag
branch
from
dcf804f to
8fa5528
Compare
kpeluso
approved these changes
Dec 17, 2024
spooktheducks
approved these changes
Dec 17, 2024
kpeluso
deleted the
tyler/proto-3083-add-mint-rewards-emissions-enabled-boolean-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
This change adds a mint module parameter that allows network administrators or the
/x/govgovernance module to control whether or not any new tokens are minted, basically entirely turning off paying for rewards and creating new tokens / inflation.Link(s) to Ticket(s) or Issue(s) resolved by this PR
PROTO-3083
Are these changes tested and documented?
New tests added to
x/mint/migrations/v5/migrate_test.goandx/mint/module/module_test.go