-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to hide bot owner in help command #713
Conversation
…/version in help command
Reviewer's Guide by SourceryThis pull request introduces a configuration option to hide the bot owner in the help command. When the option is disabled, the bot owner and version information are displayed. Sequence diagram for help command with bot owner visibility optionsequenceDiagram
actor User
participant Discord
participant HelpCommand
participant Config
User->>Discord: Invokes help command
Discord->>HelpCommand: Triggers help command
HelpCommand->>Config: Check HIDE_BOT_OWNER setting
Config-->>HelpCommand: Return visibility setting
alt HIDE_BOT_OWNER is false
HelpCommand->>HelpCommand: Add bot owner info to embed
else HIDE_BOT_OWNER is true
HelpCommand->>HelpCommand: Skip bot owner info
end
HelpCommand-->>Discord: Return help embed
Discord-->>User: Display help message
Class diagram showing Config class changesclassDiagram
class Config {
+BOT_NAME: str
+BOT_VERSION: str
+ACTIVITIES: str
+HIDE_BOT_OWNER: bool
+DEBUG: bool
}
note for Config "Added HIDE_BOT_OWNER configuration option"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @electron271 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The settings.yml.example diff appears to be truncated - please include the changes showing how to configure the HIDE_BOT_OWNER option in the example config file
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Introduce a configuration option to hide the bot owner in the help command, while also displaying the bot owner and version information when the option is disabled.
Summary by Sourcery
New Features: