Replace title with heading

- all these titles have a margin_top zero, which is an option we're removing from the component - also trying to retire the title component in favour of the heading component - so since the heading component has no margin top, logical thing is to replace the title with the heading
alphagov · Jan 28, 2025 · f8f32ea · f8f32ea
1 parent 97d67f6
commit f8f32ea
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 22 deletions.
diff --git a/app/views/content_items/service_manual_homepage.html.erb b/app/views/content_items/service_manual_homepage.html.erb
@@ -11,10 +11,11 @@
     <div class="govuk-main-wrapper">
       <div class="govuk-grid-row">
         <div class="govuk-grid-column-two-thirds">
-          <%= render "govuk_publishing_components/components/title", {
-            title: "Service Manual",
+          <%= render "govuk_publishing_components/components/heading", {
+            text: "Service Manual",
+            font_size: "xl",
+            heading_level: 1,
             inverse: true,
-            margin_top: 0,
             margin_bottom: 6,
           } %>
           <p class="govuk-body-lead app-hero-lead app-hero__body--inverse govuk-!-padding-bottom-1">

diff --git a/app/views/content_items/service_manual_service_toolkit.html.erb b/app/views/content_items/service_manual_service_toolkit.html.erb
@@ -8,10 +8,11 @@
     <div class="govuk-main-wrapper">
       <div class="govuk-grid-row">
         <div class="govuk-grid-column-two-thirds">
-          <%= render "govuk_publishing_components/components/title", {
-            title: "Design and build government services",
+          <%= render "govuk_publishing_components/components/heading", {
+            text: "Design and build government services",
+            font_size: "xl",
+            heading_level: 1,
             inverse: true,
-            margin_top: 0,
             margin_bottom: 6,
           } %>
           <p class="app-hero__description govuk-body-l govuk-!-margin-bottom-3 app-hero__body--inverse">

diff --git a/app/views/histories/10_downing_street.html.erb b/app/views/histories/10_downing_street.html.erb
@@ -4,10 +4,12 @@
 
 <header class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render "govuk_publishing_components/components/title", {
+    <%= render "govuk_publishing_components/components/heading", {
+      text: "10 Downing Street",
       context: "History",
-      title: "10 Downing Street",
-      margin_top: 0,
+      font_size: "xl",
+      heading_level: 1,
+      margin_bottom: 8,
     } %>
   </div>
 </header>

diff --git a/app/views/histories/11_downing_street.html.erb b/app/views/histories/11_downing_street.html.erb
@@ -4,10 +4,12 @@
 
 <header class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render "govuk_publishing_components/components/title", {
+    <%= render "govuk_publishing_components/components/heading", {
+      text: "11 Downing Street",
       context: "History",
-      title: "11 Downing Street",
-      margin_top: 0,
+      font_size: "xl",
+      heading_level: 1,
+      margin_bottom: 8,
     } %>
   </div>
 </header>

diff --git a/app/views/histories/1_horse_guards_road.html.erb b/app/views/histories/1_horse_guards_road.html.erb
@@ -4,10 +4,12 @@
 
 <header class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render "govuk_publishing_components/components/title", {
+    <%= render "govuk_publishing_components/components/heading", {
+      text: "1 Horse Guards Road",
       context: "History",
-      title: "1 Horse Guards Road",
-      margin_top: 0,
+      font_size: "xl",
+      heading_level: 1,
+      margin_bottom: 8,
     } %>
   </div>
 </header>

diff --git a/app/views/histories/king_charles_street.html.erb b/app/views/histories/king_charles_street.html.erb
@@ -4,10 +4,12 @@
 
 <header class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render "govuk_publishing_components/components/title", {
+    <%= render "govuk_publishing_components/components/heading", {
+      text: "King Charles Street",
       context: "History",
-      title: "King Charles Street",
-      margin_top: 0,
+      font_size: "xl",
+      heading_level: 1,
+      margin_bottom: 8,
     } %>
   </div>
 </header>

diff --git a/app/views/histories/lancaster_house.html.erb b/app/views/histories/lancaster_house.html.erb
@@ -4,10 +4,12 @@
 
 <header class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render "govuk_publishing_components/components/title", {
-      context:"History",
-      title: "Lancaster House",
-      margin_top: 0,
+    <%= render "govuk_publishing_components/components/heading", {
+      text: "Lancaster House",
+      context: "History",
+      font_size: "xl",
+      heading_level: 1,
+      margin_bottom: 8,
     } %>
   </div>
 </header>