Take down content list AB test #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
changed the title
unoduetre
force-pushed
the
3273-take-down-content-list-ab-test
branch
from
69bf86f to
c0928c8
Compare
unoduetre
commented
Feb 17, 2025
test/integration/guide_test.rb
Outdated
| @@ -34,54 +34,6 @@ class GuideTest < ActionDispatch::IntegrationTest | |||
| assert page.has_css?('.gem-c-contents-list a[href$="?token=some_token"]') | |||
| end | |||
|
|
|||
| test "does not show part navigation, print link or part title when only one part" do | |||
There was a problem hiding this comment.
Those are not necessary anymore as the logic is gone. There is a test checking, if the content list and the print link is present above.
catalinailie
approved these changes
Feb 19, 2025
unoduetre
force-pushed
the
3273-take-down-content-list-ab-test
branch
from
c0928c8 to
7148f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.
What
We will be making a decision on whether we make the content list a permanent feature if we can validate our hypothesis but this card is to remove the AB test functionality.
This PR removes the AB test. Another PR applies a change to always show content list in guides.
Why
Trello ticket