Revert spacing changes to service manual homepage #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `govuk-main-wrapper` class adds the correct spacing to the view templates and follows the design system guidance. When used on the service-manual and service-toolkit homepage, it adds extra unwanted spacing at the top of the blue banner. To fix this, the new `exclude_main_wrapper_class` method has been used to remove the `govuk-main-wrapper` class from these pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Revert spacing changes to service manual homepage
Why
The
govuk-main-wrapperclass adds the correct spacing to the view templates and follows the design system guidance.When used on the service-manual and service-toolkit homepage, it adds extra unwanted spacing at the top of the blue banner. To fix this, the new
exclude_main_wrapper_classmethod has been used to remove thegovuk-main-wrapperclass from these pages.Visual Changes
Before
Service Manual
Service Toolkit