Specialist document presenter refactor #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many facet value variables which make it confusing. Naming it what it is, which is metadata from the content item
Removed some of the nested maps and loops. Hopefully be more explicit with sequential steps of generating metadata.
ryanb-gds
reviewed
Feb 25, 2025
I think it's more like - refactoring was done by that point anyways, and for the sake of better readability and leaving things in a better state we'll just pop this PR out there. It's no longer urgent. We also stopped and rolled back the refactoring of pullings things out into its own models. |
hannako
approved these changes
Feb 25, 2025
| @@ -113,7 +113,7 @@ def facets | |||
| finder.dig("details", "facets") | |||
| end | |||
|
|
|||
| def facet_values | |||
| def content_item_metadata | |||
There was a problem hiding this comment.
This is a much better name 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follow on discussion on PR: #3565
Refactored the specialist document presenter.
Closed the previous PR as we may no longer need to manipulate the finder schema to fetch sub-facets anymore. Refactorings are stand alone.
Follow these steps if you are doing a Rails upgrade.
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.