Extract display date and time methods to a helper #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to remove duplication and also prepare for model creations so we can reuse these methods without having to rely on the ContentItem module. This also allows us to remove the stubs placed in tests and test actual values passed through.
hannako
approved these changes
Feb 25, 2025
| @@ -35,13 +35,9 @@ def withdrawal_notice_context | |||
|
|
|||
| def withdrawal_notice_time | |||
| view_context.tag.time( | |||
| english_display_date(withdrawal_notice["withdrawn_at"]), | |||
| DateTimeHelper.display_date(withdrawal_notice["withdrawn_at"], locale: :en), | |||
There was a problem hiding this comment.
Oh this is a pain isn't it! I'll make a card on the navigation backlog to log that we need a translation for
government-frontend/app/presenters/content_item/withdrawable.rb
Lines 28 to 30 in 5f635e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are duplicate code where display date is used (e.g. consultation and call for evidence). We also currently have a hard set reliance on the content item presenter to use date displays. Extracting this to a helper module will allow us to remove that coupling.
Additionally, there are stubs of the method all over tests which means tests are not testing actual values. Have removed some of this stubbing.
Follow these steps if you are doing a Rails upgrade.
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.