Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contacting patterns and pages team bold #3579

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

leenagupte
Copy link
Contributor

It's easy to miss this line, and we want avoid clashes with teams making changes in government-frontend and routes being migrated to frontend.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3579 February 28, 2025 10:24 Inactive
**Routes in this application are being migrated to another application, please check with [#govuk-patterns-and-pages](https://gds.slack.com/archives/C06T3EFUUQ6) when making changes.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should add something like 📣 to the beginning to make it stand out more, and/or have a heading like Ongoing work to be aware of, and also move it to above the CD notice? I think at the moment it still blends in too much with the existing template.

Copy link
Contributor

@AshGDS AshGDS Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, a heading would be good, and maybe a checklist item to confirm it's been considered?

e.g.

  • #govuk-patterns-and-pages have been notified of this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes. Is it too much now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the checklist above the continous deployment message and use underscores to create a line between them? i.e.

📣 On-going work to be aware of

Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.

  • #govuk-patterns-and-pages have been notified of this change

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3579 February 28, 2025 11:03 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3579 February 28, 2025 11:05 Inactive
It's easy to miss this line, and we want avoid clashes with teams making
changes in government-frontend and routes being migrated to frontend.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3579 February 28, 2025 11:16 Inactive
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leenagupte leenagupte merged commit 6252f1e into main Feb 28, 2025
12 checks passed
@leenagupte leenagupte deleted the update-PR-template branch February 28, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants