-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contacting patterns and pages team bold #3579
Conversation
.github/pull_request_template.md
Outdated
**Routes in this application are being migrated to another application, please check with [#govuk-patterns-and-pages](https://gds.slack.com/archives/C06T3EFUUQ6) when making changes.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should add something like 📣 to the beginning to make it stand out more, and/or have a heading like Ongoing work to be aware of
, and also move it to above the CD notice? I think at the moment it still blends in too much with the existing template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, a heading would be good, and maybe a checklist item to confirm it's been considered?
e.g.
- #govuk-patterns-and-pages have been notified of this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some changes. Is it too much now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put the checklist above the continous deployment message and use underscores to create a line between them? i.e.
📣 On-going work to be aware of
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.
- #govuk-patterns-and-pages have been notified of this change
Follow these steps if you are doing a Rails upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
5a55de1
to
1a1da6a
Compare
1a1da6a
to
fd123bf
Compare
It's easy to miss this line, and we want avoid clashes with teams making changes in government-frontend and routes being migrated to frontend.
fd123bf
to
a810374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It's easy to miss this line, and we want avoid clashes with teams making changes in government-frontend and routes being migrated to frontend.
Follow these steps if you are doing a Rails upgrade.
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.