Add custom css exclude list to Asset Helper #4656
Merged
+100
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
changed the title
KludgeKML
force-pushed
the
custom-css-exclude-list
branch
from
4be7861 to
23b3184
Compare
KludgeKML
force-pushed
the
custom-css-exclude-list
branch
from
23b3184 to
39482d9
Compare
KludgeKML
force-pushed
the
custom-css-exclude-list
branch
from
39482d9 to
de924eb
Compare
- Add a translation function that adds the required path to the list of components. - Make the method always use an exclusion array, which is set by another method to either an empty array or the static exclude array.
- We don't have explicit tests for when we've got exclude_css_from_static set and we're visiting the component guide. Add that test, and also replace the chained safe navigation operator with a guard clause (we might not get a request, but if we do get one, it will definitely be a request.
- this adds another option to the asset helper's css_exclude_list method - if a custom exclude list is set, return that if we're not in the component guide (ignoring the STATIC_STYLESHEET_LIST) - We want this for applications that don't use static, but will benefit from having a small number of hardcoded component styles in their application stylesheets (this is a stepping stone to getting back to a shared basic styles stylesheet without static).
- scenarios don't seem to reset config, so we also need to explicitly set this to nil in other tests
KludgeKML
force-pushed
the
custom-css-exclude-list
branch
from
de924eb to
e4ef91c
Compare
MartinJJones
approved these changes
Mar 5, 2025
Ah yeah, this is definitely not purely internal! Thanks, added! |
Merged
KludgeKML
added a commit
to alphagov/email-alert-frontend
that referenced
this pull request
Mar 6, 2025
- This version has the custom_css_exclude_list feature (alphagov/govuk_publishing_components#4656) needed for the bundle css to work without individually loading stylesheets for the bundled components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an option to supply a custom css exclude list - this is like the current list that excludes anything always supplied by static from the individual component support, but for non-static based apps, where they might as a stopgap want to provide their own application.css with a hardcoded list of styles to include, but that might not be the same list as static's list.
Also mild refactoring of the asset helper to improve test coverage.
Why
To support a bundled set of stylesheets for email-alert-frontend, as here: alphagov/email-alert-frontend#1890.
https://trello.com/c/O6JhukLu/487-remove-slimmer-email-alert-frontend
Visual Changes
None.