Adjust attachment component spacing #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
attachment-spacing
branch
from
9c44885 to
4eeebe3
Compare
AshGDS
approved these changes
Mar 5, 2025
- margin bottom of attachments was being set by margins of elements inside the component, which is brittle since the contents can vary - instead, set a default margin bottom on the component - remove inner margins - also improves spacing when attachments are included in govspeak
andysellick
force-pushed
the
attachment-spacing
branch
from
4eeebe3 to
3735128
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adjust the margins on the attachment component so that the component has a default margin bottom set on the outer element, rather than controlled by the bottom margins of inner elements sticking out.
Also make the attachment thumbnails a bit smaller on mobile.
Why
Trying to make the component margin spacing more consistent and this relates to that work. This will also improve the spacing around attachments when included inside govspeak.
Also fixes #4662
Visual Changes
Margin bottom spacing changes (blue and red outlines have been added only to clarify boundaries of the component).
Spacing when attachments contain a details element.
Improved spacing shown in govspeak:
Size of attachment thumbnail on mobile (shown at 320px).