Remove HTML form to record missing deployment #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is rarely used, if ever, as we record deployments automatically and never need to manaually do this. Removing this feature to save on maintenance and to simplify the use case for POST "/deploymenents" endpoint. We use that endpoint also as an API to record deployments from Argo. Since fixing our CSRF protection, we've broken that endpoint as we don't include csrf protection token with API requests. If we make it solely used as an API endpoint, we can remove the need to authenticate via a session, which make CSRF no longer a attack vector and remove the need to verify requests.
As we no longer need to handle form submissions, we can remove logic to handle those submissions.
sengi
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rarely used, if ever, as we record deployments automatically. Removing this feature to:
We use that endpoint also as an API to record deployments from Argo. Since fixing our CSRF protection, we've broken that endpoint as we don't include csrf protection token with API requests. If we make it solely used as an API endpoint, we can remove the need to authenticate via a session, which makes CSRF no longer an attack vector and remove the need to verify csrf protection tokens.