Fix normalising app name for deployments #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app name used to look up an existing app wasn't normalise, however the name is normalized when creating app. This prevented some deployments being recorded where the app name needed to be normalised to find the existing app. E.g. finder-frontend needs to be Finder Frontend.
theseanything
force-pushed
the
fix-normalising-app-name-for-deployments
branch
from
74b2e88 to
9264f27
Compare
samsimpson1
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app name used to look up an existing app wasn't normalise, however the name is normalized when creating app. This prevented some deployments being recorded where the app name needed to be normalised to find the existing app. E.g. finder-frontend needs to be Finder Frontend.
Also removes a Jenkins metadata, we don't need or use anymore.