Bump rubocop-govuk from 4.12.0 to 4.13.0

Gemfile.lock

@@ -233,7 +233,7 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    json (2.6.3)
+    json (2.7.1)
     json-schema (4.1.1)
       addressable (>= 2.8)
     jwt (2.7.1)
@@ -501,8 +501,8 @@ GEM
       opentelemetry-semantic_conventions
     opentelemetry-semantic_conventions (1.10.0)
       opentelemetry-api (~> 1.0)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    parallel (1.24.0)
+    parser (3.2.2.4)
       ast (~> 2.4.1)
       racc
     plek (5.0.0)
@@ -576,7 +576,7 @@ GEM
     redis (4.8.1)
     redis-namespace (1.11.0)
       redis (>= 4)
-    regexp_parser (2.8.2)
+    regexp_parser (2.8.3)
     reline (0.4.1)
       io-console (~> 0.5)
     request_store (1.5.1)
@@ -605,37 +605,38 @@ GEM
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
     rspec-support (3.12.1)
-    rubocop (1.55.0)
+    rubocop (1.59.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.3)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.29.0)
+    rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
+    rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
-    rubocop-govuk (4.12.0)
-      rubocop (= 1.55.0)
-      rubocop-ast (= 1.29.0)
-      rubocop-rails (= 2.20.2)
+    rubocop-govuk (4.13.0)
+      rubocop (= 1.59.0)
+      rubocop-ast (= 1.30.0)
+      rubocop-rails (= 2.23.0)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.22.0)
-    rubocop-rails (2.20.2)
+      rubocop-rspec (= 2.25.0)
+    rubocop-rails (2.23.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.22.0)
-      rubocop (~> 1.33)
+    rubocop-rspec (2.25.0)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
@@ -693,7 +694,7 @@ GEM
       concurrent-ruby (~> 1.0)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     version_gem (1.1.3)
     warden (1.2.9)
       rack (>= 2.0.9)

db/migrate/20200225114743_add_created_at_to_bet.rb

@@ -2,7 +2,7 @@ class AddCreatedAtToBet < ActiveRecord::Migration[6.0]
   def change
     add_column :bets, :created_at, :datetime
     Bet.reset_column_information
-    Bet.all.each do |b|
+    Bet.all.find_each do |b|
       b.update!(created_at: b.set_created_at)
     end
   end

db/migrate/20200228171904_add_permanent_to_bet.rb

@@ -2,7 +2,7 @@ class AddPermanentToBet < ActiveRecord::Migration[6.0]
   def change
     add_column :bets, :permanent, :bool, default: false
     Bet.reset_column_information
-    Bet.all.each do |b|
+    Bet.all.find_each do |b|
       b.update!(permanent: true)
     end
   end

features/step_definitions/best_bet_steps.rb

@@ -104,7 +104,7 @@
 When(/^I delete all the best bets$/) do
   @query_es_ids = []
 
-  Query.all.each do |query|
+  Query.all.find_each do |query|
     @query_es_ids << "#{query.query}-#{query.match_type}"
 
     query.bets.each do |bet|

lib/tasks/publish_external_links.rake

@@ -2,7 +2,7 @@ desc "Ensure all external links in the database are present in the publishing pl
 namespace :publish_external_links do
   desc "Send external links to the Publishing API"
   task publishing_api: :environment do
-    RecommendedLink.all.each do |link|
+    RecommendedLink.all.find_each do |link|
       puts link.link
       ExternalContentPublisher.publish(link)
     end

lib/tasks/reindex_best_bets.rake

@@ -14,7 +14,7 @@ task reindex_best_bets: :environment do
   puts "Starting to reindex #{Query.count} best bets in search_api"
   start = Time.zone.now.to_f
 
-  Query.all.each do |query|
+  Query.all.find_each do |query|
     puts "Processing: #{query.query} (#{query.match_type})"
     SearchApiSaver.new(query).save # rubocop:disable Rails/SaveBang
   end