Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RemoteSynchronizable documentation #1387

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Update RemoteSynchronizable documentation #1387

merged 1 commit into from
Feb 21, 2025

Conversation

jackbot
Copy link
Contributor

@jackbot jackbot commented Feb 21, 2025

This concern was reverted in d045d1d to the previous implementation where the
client is explicitly set as a class variable rather than by a method
call, but it looks like the documentation still reflects the previous
way.

Similarly, it no longer uses lifecycle callbacks but relies on these
methods to be explicitly called.

This concern was reverted in d045d1d to the previous implementation where the
client is explicitly set as a class variable rather than by a method
call, but it looks like the documentation still reflects the previous
way.

Similarly, it no longer uses lifecycle callbacks but relies on these
methods to be explicitly called.
@jackbot jackbot requested a review from csutter February 21, 2025 11:42
Copy link
Contributor

@csutter csutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Great spot 👍

@jackbot jackbot merged commit dba3549 into main Feb 21, 2025
10 checks passed
@jackbot jackbot deleted the remote-sync-doc branch February 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants