Simplify API client error handling #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we handle errors in API clients is a bit too complex, and too coupled to ActiveRecord (it sets model errors, possibly based on trying to parse an error string, and raises its own `ClientError`). This changes the clients to not rescue any errors from the remote API, but instead letting them bubble up to the caller, and moves the setting of record errors to the ActiveRecord-specific `RemoteSynchronizable` concern, paving the way for clients to be able to work with POROs as well.
jackbot
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we handle errors in API clients is a bit too complex, and too coupled to ActiveRecord (it sets model errors, possibly based on trying to parse an error string, and raises its own
ClientError).This changes the clients to not rescue any errors from the remote API, but instead letting them bubble up to the caller, and moves the setting of record errors to the ActiveRecord-specific
RemoteSynchronizableconcern, paving the way for clients to be able to work with POROs as well.