Change finder presenter logic for nested facets #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngocd
reviewed
Feb 25, 2025
minhngocd
force-pushed
the
change-finder-presenter-logic-for-nested-facets
branch
from
2f822d6 to
be536c4
Compare
ChrisBAshton
approved these changes
Feb 25, 2025
| @@ -27,14 +27,6 @@ def content_id | |||
| file.fetch("content_id") | |||
| end | |||
|
|
|||
| def self.facets_without_specialist_publisher_properties(facets) | |||
There was a problem hiding this comment.
It would be good to do the moving of this into FinderFacetPresenter in a separate commit to then adding the sub_facet_hash logic.
There was a problem hiding this comment.
Updated now. The refactoring is in a separate commit
minhngocd
force-pushed
the
change-finder-presenter-logic-for-nested-facets
branch
from
be536c4 to
086b703
Compare
…nter There is going to be additional logic we want to add into finder facets, which makes sense for us to pull into a separate object. The new object allows us to remove the static method currently there, and simplifies testing for facets.
…ishing-api In order to minimise the customisation in Finder Frontend, we will send the data in the shape it is typically expected by Finder Frontend, i.e. the facets are stand-alone. We still need some way of referencing the parent facet value in the children, which we're doing by setting `main_facet_value`, alongside every subfacet label-value pair in the subfacet. We also send the `main_facet_label` so we can recompose the subfacet label in the format `Main facet label - Sub facet label` when JS is disabled and all the facet options show in the select; since we have duplicates such as "Not applicable" it would be unclear which main facet option the subfacet option refers to. Other required keys are: - the `nested_facet` (T/F) flag which indicates to the Finder Frontend rendering app that the facet should be rendered as a NestedFacet (new Facet type added by us). - `sub_facet_key` and `sub_facet_name` which are only set on the main facet, used for loading the js module. - the `key` and `name` of the subfacet come from the data stored under the main facet, in the schema. - all the other key values are shared between the main and sub facets, though a case could be made in the future for also allowing the customization of the subfacet's `short_name`, `preposition`, `display_as_result_metadata` or `show_option_select_filter` values. Co-authored-by: Laura Ghiorghisor <laura.ghiorghisor@digital.cabinet-office.gov.uk>
lauraghiorghisor-tw
force-pushed
the
change-finder-presenter-logic-for-nested-facets
branch
from
086b703 to
a97cb65
Compare
lauraghiorghisor-tw
force-pushed
the
change-finder-presenter-logic-for-nested-facets
branch
from
a97cb65 to
5fd9e7c
Compare
lauraghiorghisor-tw
deleted the
change-finder-presenter-logic-for-nested-facets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing nested facets implementation. We now send two distinct facets in the publishing-api load, corresponding to the main and sub facet, respectively, in order to minimise how much we need to change Finder Frontend down the line.
Trello