-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dry specialist publisher tests #3029
Open
GDSNewt
wants to merge
6
commits into
main
Choose a base branch
from
DRY-specialist-publisher-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
12353cc
Audit access_control_spec.rb test file
ChrisBAshton 284af6a
Add a general test for creating new documents
GDSNewt 30e7f2e
Add validation to remaining document type models
GDSNewt d927acf
Delete unnecessarily duplicated "creating a ..." tests
ChrisBAshton 628b016
Remove redundant feature tests
GDSNewt 0f653f3
Consolidate model spec in general test file
GDSNewt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
122 changes: 0 additions & 122 deletions
122
spec/features/creating_a_data_ethics_guidance_document.rb
This file was deleted.
Oops, something went wrong.
144 changes: 0 additions & 144 deletions
144
spec/features/creating_a_drcf_digital_markets_research_spec.rb
This file was deleted.
Oops, something went wrong.
110 changes: 0 additions & 110 deletions
110
spec/features/creating_a_life_saving_maritime_appliance_service_station_spec.rb
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message
Delete unnecessarily duplicated "creating a ..." tests
needs updating, as it still references keeping some old tests, but the commit is entirely deletions.