Remove unused icons #3214
Merged
Remove unused icons #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
approved these changes
Jan 2, 2024
Removed the `header-crown.png` and `favicon.png` icons included in the statics asset folder as they were not in use.
MartinJJones
force-pushed
the
remove-unused-icons
branch
from
821a7e6 to
4446fc2
Compare
patrickpatrickpatrick
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the
header-crown.pngandfavicon.pngicons included in the statics asset folder as they were not in use.favicon.png
I could not find any history of where the
favicon.pngwas previously used. The favicon used in static comes from the Design System,favicon.icoheader-crown.png
The
header-crown.pngimage is no longer required, it was previously used in header-footer.css.erbWhy
As the images are no longer in use, it is best to remove them to help avoid any further work in the future to maintain / update them.
Trello card