Bump govuk_publishing_components from 37.2.4 to 37.3.0 #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 37.2.4 to 37.3.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v37.2.4...v37.3.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
The reason for the failing tests is because the Cookie Banner is now hidden by default when JavaScript is disabled, see alphagov/govuk_publishing_components#3830 Removing the checks in the 2 files below will fix this: |
As the cookie banner is now hidden when JS is disabled, these tests can't see the banner unless this code is added
AshGDS
force-pushed
the
dependabot/bundler/govuk_publishing_components-37.3.0
branch
from
86952da to
6b793ca
Compare
|
@MartinJJones Thanks - I managed to get them to pass - are you able to review my commit? |
MartinJJones
approved these changes
Feb 6, 2024
AshGDS
deleted the
dependabot/bundler/govuk_publishing_components-37.3.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk_publishing_components from 37.2.4 to 37.3.0.
Changelog
Sourced from govuk_publishing_components's changelog.
Commits
8e52c13Merge pull request #3857 from alphagov/version-37.3.0f1efcfdLock govuk-frontend version to 4.7.0ef7fa2fVersion 37.3.0971b4b0Merge pull request #3842 from alphagov/dependabot/bundler/rubocop-govuk-4.14.0095e0f2Merge pull request #3853 from alphagov/dependabot/bundler/nokogiri-1.16.2834243fMerge pull request #3851 from alphagov/separate-env-code4bdd776Update changelog702a54aAllow other analytics domain details to load580ac00Bump nokogiri from 1.16.0 to 1.16.25e02f61Merge pull request #3830 from alphagov/hide-cookie-banner-js-disabledDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)