Update create support ticket endpoint #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help distinguish better between Support API call attributes and Zendesk ticket attributes. The later are specific to the vendor and their API spec so makes sense to include the name of the vendor. It follows the pattern of PageImprovement.
No point sending properties which are `nil`
Those are needed by the Support app. See: https://github.com/alphagov/support/blob/fdf8968/app/models/zendesk/zendesk_tickets.rb Since we use keys that points to a hash we also need need to specify which attributes inside the hash should be permitted to avoid ActionController::UnfilteredParameters error.
AgaDufrat
force-pushed
the
update-create-support-ticket
branch
from
76dfe64 to
713afb4
Compare
MuriloDalRi
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add additional Zendesk ticket attributes:
Why
Those are required by apps that create Zendesk tickets:
Testing
Tested in integration with the most complex ticket.
alphagov/support#1422
Follow these steps if you are doing a Rails upgrade.