Fix for Rails 6: Zeitwerk class loading #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matugm
changed the title
matugm
changed the title
|
Thank you for the patch and detailed report! |
|
Rails 6.0.2. Can confirm this pull request fixing behavior for ROUTES checking. However output is still showing ALL actions for "unused actions". |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have reports on this gem not working in Rails 6.
I looked into this & it seems like controllers aren't loaded with
@all.eager_load!because of the new class autoloader, Zeitwerk.This code, from Rails 6
eager_load!, shows that if Zeitwerk is enabled (default in Rails 6), then it returns & does nothing.Calling
Zeitwerk::Loader.eager_load_allfixes that.