Report unused ignore lines in config #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows traceroute to report when there are unused lines in its config. ie, lines that never "match to ignore" anything. Unused lines are not just a buildup of historic cruft, they could also unintentionally ignore matching code further down the line if the regex is left in, and then it matches something else entirely.
|
@amatsuda What do you make of this change? |
|
This feels like it would be useful to my team |
|
@amatsuda Would you like to include this change? |
|
@amatsuda what do you think? |
|
@amatsuda Any thoughts? |
|
@MaximilianoGarciaRoe do you have the permissions to merge this and cut a new gem? I can make changes if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows traceroute to report when there are unused lines in its config. ie, lines that never "match to ignore" anything.
Unused lines are not just a buildup of historic cruft, they could also unintentionally ignore matching code further down the line if the regex is left in, and then it matches something else entirely.
It will currently fire all the time - up to you if you want to hide it behind an ENV.