Support future versions automatically #73
Conversation
| # then the `printProductReleases` won't display a full range of products; it will only display the | ||
| # "supportedSinceIdeVersion" product. So, instead, we set this so far in the future that IntelliJ | ||
| # might not even exist by then. | ||
| supportedUntilIdeVersion = 993.* |
There was a problem hiding this comment.
Is it worth linking to one of these, here? Also might as well use 999, who's to say that by 2099 they won't have 9+ releases per year because we're in the middle of an IDE singularity or something? :P
There was a problem hiding this comment.
Look, if there's an IDE singularity in 2099, that's someone else's problem. I'm going to be retiring in 2098 at the latest. 😉
There was a problem hiding this comment.
I'd consider it an unqualified success (on the part of Ion and IntelliJ both) if anyone ever sees a problem from this.
| jobs: | ||
|
|
||
| # Build and test plugin and provide artifact. | ||
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| runs-on: codebuild-ion-intellij-plugin-${{ github.run_id }}-${{ github.run_attempt }}-arm-3.0-large |
There was a problem hiding this comment.
Using CodeBuild here is awesome. This makes me think it might be a good idea to use CodeBuild runner in Ion-Java-Regression-Detection workflow too.
There was a problem hiding this comment.
Possibly. We can talk about it next week if you like.
Issue #, if available:
Follow-up to #72
Description of changes:
This:
JavaIonOperatorMarkerProvider.ktandIonCodeStyleSettingsProvider.ktwere updated so that they no longer rely on deprecated APIs.plugin.xmlwas updated to specify a "K2" support mode, as is required for compatibility with future versions. From what I can tell, this is largely irrelevant for our plugin since we don't interact with the Kotlin compiler.verifyPluginfor all of the versions that need to be verified. (Large CodeBuild ARM runners have 128GB disk space vs ~14GB in the GitHub hosted runners.)Build (fork)job that doesn't use CodeBuild runners, and so it can only run./gradlew buildbut not thepluginVerifytask.PluginDescriptorand all related code. We no longer need to build different versions of the plugin for different versions of the IDE.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.