Updates proguard config to fix JDK 17 toolchain + Scala Build Tool compatibility issue #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
============================================
- Coverage 67.23% 67.22% -0.01%
+ Complexity 5482 5481 -1
============================================
Files 159 159
Lines 23007 23007
Branches 4122 4122
============================================
- Hits 15468 15466 -2
- Misses 6260 6261 +1
- Partials 1279 1280 +1 ☔ View full report in Codecov by Sentry. |
tgregg
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None.
Description of changes:
When building IonJava using JDK 17 and running proguard, the resulting jar is incompatible with scala build tool and some bytecode manipulation libraries. This updates the proguard config so that proguard doesn't make those incompatible changes to our classes.
Why does this work? The
includecodekeyword tells proguard that the code of the "keep" classes may not be modified during optimization.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.