Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: general maintenance #750

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: general maintenance #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f4e2be
test(asan): drop unnecessary LSan suppressions
andyholmes Oct 29, 2024
77945e3
fix(sms): plug leaked GCancellable
andyholmes Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugins/sms/valent-sms-device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,7 @@ valent_sms_device_finalize (GObject *object)

g_queue_clear_full (&self->attachment_requests, attachment_request_free);
g_clear_pointer (&self->message_requests, g_ptr_array_unref);
g_clear_object (&self->cancellable);
g_clear_object (&self->connection);
g_clear_object (&self->get_timestamp_stmt);

Expand Down
36 changes: 0 additions & 36 deletions tests/extra/lsan.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,50 +4,14 @@
# https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/77
leak:libfontconfig.so

# https://gitlab.gnome.org/GNOME/gvfs/-/issues/577
leak:g_daemon_vfs_init

# https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/816
leak:update_custom_image_snapshot

# https://gitlab.gnome.org/GNOME/evolution-data-server/-/merge_requests/162
leak:e_contact_get_property

# FIXME: Unconfirmed (valent-notifications-plugin)
leak:gtk_media_file_extension_init

# FIXME: Unconfirmed (valent-messages-adapter,valent-sms-device)
leak:tracker_sparql_execute_cursor
leak:tracker_sparql_execute_update
leak:translate_RDFLiteral.lto_priv.0

# False positives caused by G_TEST_OPTION_ISOLATE_DIRS
leak:g_content_type_set_mime_dirs
leak:g_test_init
leak:test_do_isolate_dirs
leak:adw_init
leak:adw_style_init

# False positive in a11y stack (TODO: re-check these)
leak:gtk_accessible_attribute_set_new
leak:gtk_accessible_value_alloc
leak:gtk_at_context_create
leak:gtk_test_at_context_new

# TODO: these only seem to crop up in valent-messages-window.c
leak:libpango-1.0.so
leak:libpangocairo-1.0.so

# librsvg
leak:librsvg-2.so

# GLib
leak:g_quark_init

# GTK
leak:libEGL_mesa.so
leak:gtk_init

# libpeas-loader-python3
leak:libpython3.9

Loading