Skip to content

Commit

Permalink
Release 1.2.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Angel Nikolov committed Jun 5, 2019
1 parent 86ea8c2 commit 5725bd8
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion dist/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-cacheable",

This comment has been minimized.

Copy link
@esotrope

esotrope Oct 1, 2019

Just curious, why is this package prefixed with ngx- when it does not depend on @angular libraries? I have to say it threw me for a loop when evaluating caching decorator libs.

Anyway, thanks for the library - cheers.

This comment has been minimized.

Copy link
@angelnikolov

angelnikolov Oct 2, 2019

Owner

@esotrope This is something I thought about a lot recently and I will maybe rename the library.
Initially, the library was prefixed ngx- because it was a client-side specific one and it was also created in the context of a large Angular project. Later it evolved in a platform-agnostic library but the name remained. I will fix that soon :) Thanks for the feedback!

"version": "1.2.2",
"version": "1.2.3",
"description": "Promise/Observable cache decorators",
"main": "./index.js",
"types": "./index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion dist/promise.cacheable.decorator.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/promise.cacheable.decorator.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-cacheable",
"version": "1.2.2",
"version": "1.2.3",
"description": "Promise/Observable cache decorators",
"main": "./index.js",
"types": "./index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion promise.cacheable.decorator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ export function PCacheable(cacheConfig: ICacheConfig = {}) {

return response;
})
.catch(_ => {
.catch(error => {
removeCachePair(pendingCachePairs, parameters, cacheConfig);
return Promise.reject(error);
});
/**
* cache the stream
Expand Down

0 comments on commit 5725bd8

Please sign in to comment.