Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump binsync #1369

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Bump binsync #1369

merged 2 commits into from
Jan 26, 2025

Conversation

mahaloz
Copy link
Member

@mahaloz mahaloz commented Jan 26, 2025

Fixes the following bug:

Exception in thread Thread-15 (_commit_hook_based_changes):
Traceback (most recent call last):
  File "D:\My Program Files\Python313\Lib\threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "C:venvs\angr\Lib\site-packages\ipykernel\ipkernel.py", line 766, in run_closure
    _threading_Thread_run(self)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "D:\My Program Files\Python313\Lib\threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:venvs\angr\Lib\site-packages\binsync\controller.py", line 454, in _commit_hook_based_changes
    self.commit_artifact(*args, **kwargs)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "C:venvs\angr\Lib\site-packages\binsync\controller.py", line 34, in _init_check
    raise RuntimeError("Please connect to a repo first.")
RuntimeError: Please connect to a repo first.

@mahaloz
Copy link
Member Author

mahaloz commented Jan 26, 2025

Linked fix: binsync/binsync@dafea5d

@ltfish ltfish added the bug label Jan 26, 2025
@ltfish ltfish merged commit eb290a4 into master Jan 26, 2025
27 checks passed
@ltfish ltfish deleted the fix/bump_binsync branch January 26, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants