Create a new pull request by comparing changes across two branches #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-based stylesheets (#57613) The AOT compiler now has the capability to handle component stylesheet files as external runtime files. External runtime files are stylesheets that are not embedded within the component code at build time. Instead a URL path is emitted within a component's metadata. When combined with separate updates to the shared style host and DOM renderer, this will allow these stylesheet files to be fetched and processed by a development server on-demand. This behavior is controlled by an internal compiler option `externalRuntimeStyles`. The Angular CLI development server will also be updated to provide the serving functionality once this capability is enabled. This capability enables upcoming features such as automatic component style hot module replacement (HMR) and development server deferred stylesheet processing. The current implementation does not affect the behavior of inline styles. Only the behavior of stylesheet files referenced via component properties `styleUrl`/`styleUrls` and relative template `link` elements are changed by enabling the internal option. PR Close #57613
…transformation support (#57613) To provide support for HMR of inline component styles (`styles` decorator field), the AOT compiler will now use the resource host transformation API with the Angular CLI to provide external runtime stylesheet URLs when the `externalRuntimeStyles` compiler option is enabled. This allows both a component's file-based and inline styles to be available for HMR when used with a compatible development server such as with the Angular CLI. No behavioral change is present if the `externalRuntimeStyles` option is not enabled or the resource host transformation API is not used. An `order` numeric field is also added to the transformation API which allows consumers such as the Angular CLI to create identifiers for each inline style in a specific containing file. PR Close #57613
Currently we don't defer any symbols that have references outside of the `import` statement and the `imports` array. This is a bit too aggressive, because it's possible that the symbol is only used for types (e.g. `viewChild<SomeCmp>('ref')`) which will be stripped when emitting to JS.
These changes expand the logic so that references inside type nodes aren't considered.
**Note:** one special case is when the symbol used in constructor-based DI (e.g. `constructor(someCmp: SomeCmp)`, because these constructors will be compiled to `directiveInject` calls. We don't need to worry about them, because the compiler introduces an addition `import * as i1 from './some-cmp';` import that it uses to refer to the symbol.
Fixes #55991.
PR Close #58104
This commit updates the `fetch` patch for zone.js. Currently, we're attaching an `abort` event listener on the signal (when it's provided) and never removing it. We should be good citizens and remove event listeners whenever objects need to be properly collected. In Firefox, when saving a heap snapshot and running it through `fxsnapshot`, querying `AbortSignal` will print a so-called "CaptureMap" with a list of "lambdas," indicating that the signal is not garbage collected because of the event listener lambda function. PR Close #57882
See associated pull request for more information. PR Close #58099
See associated pull request for more information. PR Close #58108
See associated pull request for more information. PR Close #58107
See associated pull request for more information. PR Close #58116
…ing TCB information (#58106) Whenever information is requested from the template checker right now, the shim is only ensured to be generated for the single file/component. This is slow in migrations where we don't want to collect diagnostics, but rather request information from the component state. This commit supports `OptimizeFor` in `checker#getTemplate`. PR Close #58106
) Instead of inspecting all types of property accesses, we can use a similar optimization we did for TS references— leveraging the list of known field names to minimize type checker calls. PR Close #58106
…e extension (#58106) This commit adds support for converting decorator queries to signal queries via the VSCode extension. Note that this is not fully finished as we still need to add better messaging when certain fields could not be migrated. In addition, it's worth noting that the migration is not as safe as the input migration because commonly query lists are passed around— this quickly can break the build— but is an acceptable trade-off for the work saved. A migration cannot be 100% correct in general; there are always edge-cases. PR Close #58106
GulajavaMinistudio
merged commit 96903f8
into
angular-indonesia:main
4 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information