feat(ios): proximity flow #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <berend@animo.id>
berendsliedrecht
force-pushed
the
ios-mdoc
branch
from
61b851d to
b1fcc65
Compare
TimoGlastra
requested changes
Jan 23, 2025
apps/easypid/src/features/share/FunkeOpenIdPresentationNotificationScreen.tsx
Outdated
Show resolved
Hide resolved
| "expo": "catalog:" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/fast-text-encoding": "^1.0.3" | ||
| }, | ||
| "expo": { |
There was a problem hiding this comment.
Do we need this in every package?
There was a problem hiding this comment.
every package that has the expo dependency I added it.
It should only be required for expo + one of the excluded dependencies. But this suffices imo. We can remove it when we move to expo 52.
| #import <ReactCommon/RCTTurboModule.h> | ||
|
|
||
| -#import "turboModuleUtility.h" | ||
| +#import <anoncreds/turboModuleUtility.h> |
There was a problem hiding this comment.
Is this because of static? Can we add this to the library itself by detecting the mode with an #if or something (for later, but so we can use the libraries without patches)
There was a problem hiding this comment.
I am not really sure why we had to change this. It will be removed in the new architecture as well.
Signed-off-by: Berend Sliedrecht <berend@animo.id>
berendsliedrecht
force-pushed
the
ios-mdoc
branch
from
42a0738 to
3f87247
Compare
TimoGlastra
approved these changes
Jan 24, 2025
berendsliedrecht
force-pushed
the
ios-mdoc
branch
3 times, most recently
from
8c7850a to
3c727e8
Compare
Signed-off-by: Berend Sliedrecht <berend@animo.id>
berendsliedrecht
force-pushed
the
ios-mdoc
branch
from
3c727e8 to
fdf7af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht berend@animo.id