Merge pull request #26 from ankurugranpa/#25_buf_all_status

feat: #25 all_statusメソッドのバグ修正
ankurugranpa · Jan 6, 2025 · d458f41 · d458f41
2 parents 9cefdb5 + a8ce679
commit d458f41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/model.cpp b/src/model.cpp
@@ -114,8 +114,8 @@ double Model::kl_divergence(const Model& model){
 
 DataSet Model::all_status(){
   DataSet st;
-  rbm_utils::Binary binaryer(visible_dim);
-  for(int i=0; i<std::pow(visible_dim, 2); i++){
+  rbm_utils::Binary binaryer(visible_dim+hidden_dim);
+  for(int i=0; i<std::pow(2, visible_dim+hidden_dim); i++){
     st.push_back(binaryer.num2binary(i));
   }
   return st;

diff --git a/test/model_test.cpp b/test/model_test.cpp
@@ -112,10 +112,10 @@ TEST_F(ModelTest, CostFunc){
 
 TEST_F(ModelTest, AllStatus){
   DataSet status = rbm_model.all_status();
-  rbm_utils::Binary gen_bit(rbm_model.visible_dim);
+  rbm_utils::Binary gen_bit(rbm_model.visible_dim+rbm_model.hidden_dim);
 
   // std::cout << status.size() << std::endl;
-  for(auto i=0u; i<status.size(); i++){
+  for(auto i=0; i<64; i++){
     std::cout << status[i].transpose() << std::endl;
     ASSERT_EQ(status[i], gen_bit.num2binary(i));
   }