Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code to build and upload Community Execution Environment via Github Action #76

Merged
merged 36 commits into from
Jun 4, 2024

Conversation

anweshadas
Copy link
Contributor

@anweshadas anweshadas commented May 8, 2024

Automates Community Execution Environment release process. This applies to both community-ee-minimal and community-ee-base.

Copy link

Copy link

Copy link

@anweshadas anweshadas marked this pull request as draft May 8, 2024 18:58
Copy link

Copy link

@anweshadas anweshadas force-pushed the action branch 3 times, most recently from 3894a49 to b3f8d5c Compare May 9, 2024 18:59
@anweshadas anweshadas requested a review from felixfontein May 11, 2024 00:37
Copy link

Copy link

@kurokobo kurokobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this!
I did not look closely at every detail, but I did comment on a few things I noticed.

Also, should the docs be updated as well? :https://github.com/ansible-community/images/tree/main/docs/community-ee

I haven't looked at the steps which should be performed or not in the workflow in the first place (e.g., eertest), as I believe there is a RH policy on that. But IMO the tests and the entire flow could be simplified a bit more.

Thanks 😃

.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
@anweshadas
Copy link
Contributor Author

Hi, thanks for working on this! I did not look closely at every detail, but I did comment on a few things I noticed.

Also, should the docs be updated as well? :https://github.com/ansible-community/images/tree/main/docs/community-ee

I haven't looked at the steps which should be performed or not in the workflow in the first place (e.g., eertest), as I believe there is a RH policy on that. But IMO the tests and the entire flow could be simplified a bit more.

Thanks 😃

Yes, I will work on the documentation once this PR is merged.

Copy link

Copy link

Copy link

.github/workflows/eerelease.yml Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
Copy link

Copy link

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some more unresolved comments above.

.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
.github/workflows/eerelease.yml Outdated Show resolved Hide resolved
anweshadas and others added 3 commits June 4, 2024 20:43
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Copy link

@felixfontein felixfontein merged commit ae6a4f0 into ansible-community:main Jun 4, 2024
6 checks passed
@felixfontein
Copy link
Collaborator

@anweshadas thanks for working on this!
@kurokobo thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants