Fix desktop reference counting #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment the desktop instance's "application reference count" in Design.__enter__ instead of Design.__init__ to avoid increasing the reference count incorrectly when, for example, Hfss.set_active_design is called. Fixes #4092
ghost
requested review from
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4094 +/- ##
==========================================
+ Coverage 81.86% 81.87% +0.01%
==========================================
Files 184 184
Lines 63987 63966 -21
==========================================
- Hits 52380 52374 -6
+ Misses 11607 11592 -15 |
Add a test for the behavior described in issue 4092, and fix the reference counting logic so that the reference count is decremented from even from one to zero. This ensures that the reference count is correct even if the desktop instance is not design-initialized and so is not released by Design.__exit__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment the desktop instance's "application reference count" in
Design.__enter__instead ofDesign.__init__to avoid increasing the reference count incorrectly when, for example,Hfss.set_active_designis called.Also remove unnecessarily duplicated
__enter__definitions in each application subclass, leaving onlyDesign.__enter__.Fixes #4092