Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-processing refactoring #4410

Merged
merged 31 commits into from
Apr 4, 2024
Merged

Post-processing refactoring #4410

merged 31 commits into from
Apr 4, 2024

Conversation

gmalinve
Copy link
Contributor

No description provided.

@gmalinve gmalinve added the maintenance Package and maintenance related label Mar 25, 2024
@gmalinve gmalinve self-assigned this Mar 25, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve requested a review from Alberto-DM March 25, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 33.71824% with 287 lines in your changes are missing coverage. Please review.

Project coverage is 34.61%. Comparing base (3012455) to head (cc3eb6f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4410       +/-   ##
===========================================
- Coverage   81.49%   34.61%   -46.89%     
===========================================
  Files         109      109               
  Lines       53251    53276       +25     
===========================================
- Hits        43398    18440    -24958     
- Misses       9853    34836    +24983     

Devin-Crawford
Devin-Crawford previously approved these changes Mar 26, 2024
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @gmalinve. It is important to have consistent naming.

@gmalinve gmalinve changed the title methods refactoring Post-processing refactoring Mar 27, 2024
@gmalinve gmalinve added this to the PyAEDT v1.0 milestone Mar 27, 2024
@PipKat
Copy link
Member

PipKat commented Apr 3, 2024

@gmalinve Sorry for so many suggested edits to contents that existed long before this PR. The docstrings are no longer very clean, so I viewed this as an opportunity to clean up those that I could edit in this PR.

SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 4, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good idea to leverage the handler to deprecate old argument names.

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 maxcapodi78 dismissed stale reviews from SMoraisAnsys and themself via b6cc6a1 April 4, 2024 12:06
maxcapodi78 and others added 3 commits April 4, 2024 14:07
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @gmalinve !

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) April 4, 2024 15:08
@maxcapodi78 maxcapodi78 merged commit 6125897 into main Apr 4, 2024
15 checks passed
@maxcapodi78 maxcapodi78 deleted the refacto_keywords_args branch April 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants