-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-processing refactoring #4410
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4410 +/- ##
===========================================
- Coverage 81.49% 34.61% -46.89%
===========================================
Files 109 109
Lines 53251 53276 +25
===========================================
- Hits 43398 18440 -24958
- Misses 9853 34836 +24983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @gmalinve. It is important to have consistent naming.
# Conflicts: # pyaedt/modules/PostProcessor.py
@gmalinve Sorry for so many suggested edits to contents that existed long before this PR. The docstrings are no longer very clean, so I viewed this as an opportunity to clean up those that I could edit in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good idea to leverage the handler to deprecate old argument names.
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @gmalinve !
No description provided.