enable modernize-* checks in clang-tidy #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
wxyucs
added
kind/improvement
wxyucs
requested review from
inabao,
ShawnShawnYou,
LHT129 and
jiaweizone
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 91.16% 91.14% -0.02%
==========================================
Files 134 134
Lines 8736 8734 -2
==========================================
- Hits 7964 7961 -3
- Misses 772 773 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jiaweizone
approved these changes
Feb 5, 2025
| @@ -31,7 +31,7 @@ | |||
| namespace vsag { | |||
|
|
|||
| struct SlowTaskTimer { | |||
| explicit SlowTaskTimer(const std::string& name, int64_t log_threshold_ms = 0); | |||
| explicit SlowTaskTimer(std::string name, int64_t log_threshold_ms = 0); | |||
There was a problem hiding this comment.
minor: why remove const& ?
There was a problem hiding this comment.
@jiaweizone it's changed to std::move() in utils.cpp:L26
inabao
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.