Poision and Stop will now use Context mechanics in favor of a WaitGroup. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perbu
reviewed
Jan 5, 2025
actor/engine.go
Outdated
| // e.SendLocal(pid, pill, nil) | ||
| // return _wg | ||
| // } | ||
|
|
There was a problem hiding this comment.
Do you really need to keep this around?
perbu
reviewed
Jan 5, 2025
perbu
approved these changes
Jan 5, 2025
tprifti
reviewed
Jan 5, 2025
actor/process.go
Outdated
| } | ||
|
|
||
| func (p *process) PID() *PID { return p.pid } | ||
| func (p *process) Send(_ *PID, msg any, sender *PID) { | ||
| p.inbox.Send(Envelope{Msg: msg, Sender: sender}) | ||
| } | ||
| func (p *process) Shutdown(wg *sync.WaitGroup) { p.cleanup(wg) } | ||
| func (p *process) Shutdown() { | ||
| // p.cleanup() |
There was a problem hiding this comment.
I guess we need to call cleanup here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.