[pull] main from dotnet:main #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…expression to an implicit object creation expression
…deAnalysis.CSharp.txt
* Partial events and constructors: attributes * Update pre-existing tests * Fixup expected PEVerify output * Check a flag before materializing syntax nodes * Assert that the definition part of an event doesn't have accessors * Keep pre-existing event attribute target behavior * Improve code * Add WorkItem attribute * Strengthen asserts Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> --------- Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
…expression to an implicit object creation expression (#77279)
…7-implement-method
…ence-packages build 20250219.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.608004 -> To Version 10.0.611901
…/ankitakhera/aai_doc_comments
# Problem Rename flyout is being cropped on small screens. The issue being that: 1. The flyout is larger than the document's view port 2. The flyout's left position is negative (which makes it disappear to the left). 3. Text within the flyout doesn't wrap.  # Solution Basically, address all of the above: 1. Limit the size of the flyout to the width of the document's view port. 2. Ensure the flyout's position is always positive. 3. Wrap text blocks. 
This shouldn't be needed anymore, and prevents some design time build breaks if NuGet restore wasn't able to get this package. Fixes #74923
…ence-packages build 20250310.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.615601 -> To Version 10.0.616001
#77518) This pull request updates the following dependencies [marker]: <> (Begin:4e88e544-5668-4a45-0f48-08dc0c57b4c0) ## From https://github.com/dotnet/source-build-reference-packages - **Subscription**: 4e88e544-5668-4a45-0f48-08dc0c57b4c0 - **Build**: [20250310.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2659508) - **Date Produced**: March 10, 2025 4:22:48 PM UTC - **Commit**: [8f9f6fa14523b2f2475ea0a86be1cf60b5de5336](dotnet/source-build-reference-packages@8f9f6fa) - **Branch**: refs/heads/main [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.SourceBuild.Intermediate.source-build-reference-packages**: [from 10.0.615601 to 10.0.616001][1] [1]: dotnet/source-build-reference-packages@232bcf3...8f9f6fa [DependencyUpdate]: <> (End) [marker]: <> (End:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
see test below
```
[InlineData("int myField;", typeof(FieldDeclarationSyntax))]
public async Task TestInvalidNodeReplacement(string syntax, Type type)
```
…cess (#77546) NFW telemetry indicates Solution.Workspace is getting called in our server process. This is due to a recent change I made around immediate eventing. In the server process, there are no immediate (or standard) workspace event handlers, but due to this recent changewe were always calling RaiseEventForHandlers for the immediate handlers without checking for their presence.
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
…nsure that it happens when needed (pack) (#77515) During the most recent SDK insertion, allocation regressions were reported in the C# editing speedometer test. Investigation yielded that these were because of restore failures in the test project as the runtime packages are not published at the point of the SDK insertion. Looking at the MS.CodeAnalysis.LanguageServer project closer revealed that these runtime identifiers needed to only be set during the pack task. This PR moves setting the RuntimeIdentifiers property to only be done during the pack task, and thus the restore task won't attempt to download these packages. As the test doesn't perform a pack on the roslyn solution, this should prevent future SDK insertions from hitting this issue again.
Update IDocumentNavigationService implementation in VS to work on any TextDocument Fix IDocumentNavigationService extension to use TextDocument Fix Stack Trace Explorer to search for AdditionalDocuments when trying to find a match in file path or name Partial fix for #77499 There might be more cases where finding symbols doesn't work but filepath+line navigation should now work
Offers 💡 `Implement Using Copilot` when `NotImplementedException` is present in code. https://github.com/user-attachments/assets/488bcb97-0f4a-48b1-a020-9627014f31c8
…311.4 (#77569) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25161.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )