[pull] master from web-platform-tests:master #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is no longer support in Python 3.13, and no longer required for Python>=3.8
This avoids the use of imghdr which was removed in Ptyhon 3.13
Remove the long-outdated interface expectation file interfaces/sanitizer-api.tentative.idl. Note that the current interface remains, at interfaces/sanitizer-api.idl. Bug: 356601280 Change-Id: I78df1eeff74350851237a4f414ed66a6a7bb299d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6291304 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427651}
Also make these additional changes: - Add encoding="utf-8" parameter to file open calls to work correctly if the OS system default encoding is not UTF-8. - Remove $ and , from exclude_std3 set as in IdnaTestV2.txt of UTS46 16.0.0 they are correctly labeled as U1. - Filter :, /, ?, #, and \ directly in IdnaTestV2-parser.py.
Some code points not allowed in the previous Unicode version are ignored/mapped in Unicode 16.0 (according to the IdnaMappingTable.txt file): * U+180E and U+206B are ignored * U+04C0 - mapped to U+04CF * U+2183 - mapped to U+2184 Related to #48301.
This is needed for future enhancements to these tests
And the script used to find them.
Since this test was added, the prelude grammar has grown quite a bit; add some new cases to verify that we actually respect <declaration-value>. Fixed: 389951206 Bug: 325504770 Change-Id: Iaf7751c537aa580582a04f19383df3fc06215992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6322427 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427654}
…ction see w3c/webrtc-pc#131 Drive-by: disable WPT for "url" in stats, this is not testable in WPT BUG=webrtc:42222542 Change-Id: Id5205993c82e9b0b88316d3d1e6e40d341e9b765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313874 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427694}
Replace command invoker clickOn with .click call on button This allows the tests to be run in a normal browser, there's no need for a trusted click so this is equivalent.
Changes in this CL: - The origin defined in the scope parameters were not yet used outside of for validation. This CL threads through the scope origin when creating the session. If none is provided, it uses the fetcher URL. - Existing validation code treated the scope origin as a host. This CL modifies the handling to treat the scope origin as an origin. - New WPT is added: set-scope-origin.https.html Bug: 353767385 Change-Id: I05542bde6cfdb5b826848860e3a96f11603ee013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6321908 Reviewed-by: Daniel Rubery <drubery@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: thefrog <thefrog@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427820}
This CL introduces parsing for the `row-rule-color` property which sets the color of the gap decorations in rows see: https://drafts.csswg.org/css-gaps-1/#column-row-rule-color Bug: 357648037 Change-Id: I26bddb4e531bcc58b93247a8dc7220aa5e23da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288989 Commit-Queue: Javier Contreras <javiercon@microsoft.com> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1427827}
This is no longer needed as CommandEvent is tested by html/dom/idlharness.any.js
This CL augments https://crrev.com/c/6101656, by painting the row-rule cases in `PaintGridGaps`. This uses the newly introduced `row-rule` properties. This CL also updates the relevant tests to test the painting of row gaps. Bug: 357648037 Change-Id: I48ea54761df0675297969a7b051839509a567168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300029 Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Javier Contreras <javiercon@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1427843}
* `performance` should be available for `window` and workers * `performance.eventCounts` is only available on `window` * `performance.interactionCounts` has been renamed and is no longer an interface. Bug: 40231541 Change-Id: I50b834dbd408a61512faf91f59bbc71f8a945c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6322853 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Michal Mocny <mmocny@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427902}
When we are removing all children (e.g. from a call to set innerHTML), we skip notifying of each child removal. This fixes MouseEventManager to also watch for all children removal and update tracked nodes in response. Bug: 40839619, 40941145 Change-Id: I219904d6ba8596c9b9715b6fdf08576d5f026f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313963 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427868}
The style's render-blocking status should be preserved when it is moved, but the style must be un-applied and re-applied, as the location of the style in the DOM has significance. Bug: 394380744 R=dom@chromium.org Change-Id: I26404c40bd58f36c8b7e205533c8d3328e21fe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304605 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427964}
The whole animation-only traversal thing is quite messy, but it can generally no longer assert that it only deals with already-styled subtrees, since we want to make display animatable. Make it more in line with the regular traversal, in order not to leave the tree in an inconsistent state (an element with display != none that has unstyled children), which the frame constructor complains about (rightfully so). Differential Revision: https://phabricator.services.mozilla.com/D240307 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1941651 gecko-commit: 52430cf390952929710e421e7bb9be13d1608f77 gecko-reviewers: dshin
border-*-width is not on the list of properties with resolved values: https://drafts.csswg.org/cssom-1/#resolved-values This used to be more useful when our buttons and so on didn't respect the UA sheet borders. Let's try to do this? Otherwise we should file a bug to change the spec. Differential Revision: https://phabricator.services.mozilla.com/D240312 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1951562 gecko-commit: 477f5c91a780c74f7ec50e8b44790b947b258bc2 gecko-reviewers: layout-reviewers, dholbert
…cope The added tests check that the order of ids in the serialized value of anchor-scope is canonical (i.e the order is identical to the order in the specified value)
…tests to match spec The syntax for position-visibility has changed since the parsing/computed tests were created, so update them to match the spec. Also mark them as non-tentative.
Change recently added tests to actually test the ordering. Bug: 399478940 Change-Id: Ia9d88d3658868dde12268a8b7fc21ffec30505c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6323105 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427991}
New subtest in ElementInternals-validation.html is failing because the variable validity isn't defined. We fix this by adding `const validity = control.i.validity`. Change-Id: I8e88170011558b2c03262f2302cb42db88e06ea9 Fixed: 400504635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6325209 Reviewed-by: Traian Captan <tcaptan@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1428024}
Apply https://crrev.com/c/6341204 to iframe tests. Fixed: 392539092 Test: run_wpt_tests.py --product=chrome external/wpt/*/*iframe-access* Test: 4/7 tests run expectedly instead of timing out Change-Id: I0ed66d6d5a00ab06e0f1fa0ca6383446c896c28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6353118 Reviewed-by: Arnaud Mandy <arnaud.mandy@intel.com> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Auto-Submit: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1432368}
On some test runners the test can take so long to run that by the time we try to use the HSTS entry it has already expired. This leads to failures such as https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/125174/overview This CL increases the max-age so the entry exists long enough to check. Change-Id: I1ae1e1a1eb817ddef254cdeabf53eec7e091de8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354623 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by: Dustin Mitchell <djmitche@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432382}
…51247) * Revert "[DC] Fix/Improve Digital Credentials permission policy wpt" This reverts commit 916aab9. Some of the assumptions made in the above PR commit were, which causes both UI lock and are not to spec. * Apply suggestions from code review * Update digital-credentials/disabled-by-permissions-policy.https.sub.html * Update digital-credentials/disabled-by-permissions-policy.https.sub.html
Differential Revision: https://phabricator.services.mozilla.com/D241320 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1953144 gecko-commit: 454852d50d040b55ed9e31c61960e2c77b9d7153 gecko-reviewers: emilio
These are the new tests that were included in fantasai's patch D45948. With the patch that landed in bug 1949064 they should all now pass. Differential Revision: https://phabricator.services.mozilla.com/D241262 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1095937 gecko-commit: bb95e001c5267def7ba8d1bfd0cc4dc127e141bd gecko-reviewers: layout-reviewers, emilio
Replacing the innards of a scroll marker group when it gets laid out by a sibling (the scroller) requires more rocket surgery than what we had. Just update the propagated_data_ member, which happens to contain any snap areas (and other goodies too, which should benefit from being carried over properly). Move MutableForOofFragmentation::Merge() into the .cc file, since it's a grown-up function now. Bug: 402354445 Change-Id: I1893d5d0390c0f113d7ba648a8ba68c842e02005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352056 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432592}
The CSSWG found the existing names: "high", "constrained-high", "standard" to be unintuitive and has changed them to "no-limit", "constrained", "standard" Bug: 396459454 Change-Id: I72fcabf9c9eb24b2ded8db0a38eb64f5c734c26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6348901 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432603}
…ange." This reverts commit debeece9d8f6dee2750cd9ff54203ad53c94b838. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8720431738035216721 Sample failed build: https://ci.chromium.org/b/8720431738035216721 If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6352056&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8720431738035216721&type=BUG Original change's description: > [carousel] Update marker group scroll snap areas when they change. > > Replacing the innards of a scroll marker group when it gets laid out by > a sibling (the scroller) requires more rocket surgery than what we had. > Just update the propagated_data_ member, which happens to contain any > snap areas (and other goodies too, which should benefit from being > carried over properly). > > Move MutableForOofFragmentation::Merge() into the .cc file, since it's a > grown-up function now. > > Bug: 402354445 > Change-Id: I1893d5d0390c0f113d7ba648a8ba68c842e02005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352056 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1432592} > Bug: 402354445 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie859ec37e84d280e7d1860b5d73083244cd9b3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6356873 Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1432612}
Tree-counting functions such as sibling-index() do not have a useful interpretation in contexts where there are no elements involved. For instance in @media queries and @font-face descriptors. This is currently not per any specification, but there is an open issue for it: w3c/csswg-drafts#10982 We still allow sibling-index() in @page properties with this CL. Bug: 40282719 Change-Id: I10b939d1981e9eb3347f18a7ef292cdd425b3cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352179 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432625}
Our current implementation doesn't set the `accept-signature` header for scripts running through the parser's preload mechanism. This CL ensures that we attach public keys to that outgoing request so that the network stack does the right thing. Change-Id: If294983081a3e761ccd97888a6572bb787fb43e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6346908 Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432680}
Fix "isChaff" parsing so that it matches the spec by requiring the value to be the correct type when present. Also update biddingGroup to be optional to match the parsing behavior specified in privacysandbox/draft-ietf-bidding-and-auction-services#20 Bug: 403014301 Change-Id: I5ead4c4bc4ed003c75a2292a8a75aba4a9209557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352817 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/main@{#1432714}
This CL adds more cases described in the design doc: https://docs.google.com/document/d/1LKEX8eb34SDbPQcd0XpaYigzczipJmSejqWC5I93tYQ/edit?tab=t.0#heading=h.1m7kpf6i9083 - Case 1 to `redirect-to-prefetch-url.https.html` - Case 2/3 to `redirect-middle-of-prefetch.https.html` expecting the prefetched result is not used for serving in these cases. See WICG/nav-speculation#367. Bug: 403156549 Change-Id: I80557206aed6ff8c52fe7711013c08e2516dfcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5627186 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1432783}
This patch adds the currently focused element and whether the select element is open to each event logged in this test to better define what the event handling behavior is. Change-Id: Ia078b90f297388db861eb670af632bc593bdfd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349394 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1433053}
…dule until it's disabled in the release channel We added a lot of crash tests for tricky cases for the editor module. Some of them use the legacy DOM mutation events, and some of them caused serious issues. Thus, we should enable the DOM mutation events at least running the tests to detect regressions as soon as possible. Differential Revision: https://phabricator.services.mozilla.com/D240709 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1952410 gecko-commit: 1ec3b9a31429a53d03b880623f924ca40f587a1c gecko-reviewers: smaug, m_kato
by a new src attribute value, for example. Differential Revision: https://phabricator.services.mozilla.com/D241362 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1951744 gecko-commit: 9d1bf78f062a668103d378e4dfb4732ccec844f2 gecko-reviewers: media-playback-reviewers, padenot
…essor DOM API. Differential Revision: https://phabricator.services.mozilla.com/D241227 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1953525 gecko-commit: c189238622049ece3621952d463afdab4dd5dfd1 gecko-reviewers: smaug
…1">` to avoid scaling down the content. With it, we can avoid pixel alignments in the content. Differential Revision: https://phabricator.services.mozilla.com/D241511 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1953975 gecko-commit: 46d518a4126651924edd56d7f2b793f55da30c36 gecko-reviewers: boris
…Docs. onchange-event-subframe.html has a bug that it doesn't wait for completion of orientation.unlock(). But since GeckoView's test runner doesn't implement unlock(), this test is unfortunately passed. When implementing it and fix the test bug, this test is failed on Gecko. Also, this test is for 8.4 of [*1]. A change event is fired by descendantDocs. But actually, Gecko doesn't consider the order by document tree. So we should dispatch it from top to bottom. *1 https://w3c.github.io/screen-orientation/#screen-orientation-change Differential Revision: https://phabricator.services.mozilla.com/D240117 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1951330 gecko-commit: fd384baaa2b39814950e2df444f3e37bd32dd690 gecko-reviewers: dom-core, geckoview-reviewers, calu, edgar
Differential Revision: https://phabricator.services.mozilla.com/D241071 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1952250 gecko-commit: 824d8c4e02e112468d0feed9cc248c69b6aa5d1b gecko-reviewers: emilio
This helps with libraries like https://github.com/jsdom/tr46 which separately implement TR46 ToASCII versus the URL Standard's "domain to ASCII". Part of #51368.
Because we were using var instead of let, the closure was capturing only the last value for test_case. So we were only ever running one of the setter test cases (repeatedly) per property. A minor fix would be to move from var to let. But, instead I just modernized these files completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )