solana-vote-interface: deprecate VoteState::commission_split #11
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
clean/deprecate-vote-commission
branch
from
253cbac to
90a8b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commission split logic should live in the runtime rather than the sdk in my opinion. I need to use this logic on a new runtime vote state view type introduced in anza-xyz/agave#4834 without creating an instance of a
VoteState. The logic will be moved into the runtime here: anza-xyz/agave#4876. Rather than keeping two copies of this logic, let's deprecate and remove the method here since I don't think it's that useful to clients.